Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR grom72/trivy #16

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

PR grom72/trivy #16

wants to merge 23 commits into from

Conversation

grom72
Copy link
Owner

@grom72 grom72 commented Jul 31, 2024

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

grom72 added 23 commits June 25, 2024 16:53
Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
This reverts commit 4ad656b.

Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
This reverts commit f5105c5.

Signed-off-by: Tomasz Gromadzki <[email protected]>
Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Skip-test: true
Skip-unit-test: true
Skip-func-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Skip all functional tests
Doc-only: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Doc-only: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Doc-only: true
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Doc-only: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Doc-only: true

This reverts commit bceb0ac.

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
This reverts commit 666e3b9.
Doc-only: true
Signed-off-by: Tomasz Gromadzki <[email protected]>
Required-githooks: true
Doc-only: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
This reverts commit 3036508.
Doc-only: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant