Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap default mode, rename opt-out mode to v0 #4766

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Feb 5, 2025

https://deploy-preview-4766--rad-shortbread-897892.netlify.app/

What does this PR do?

Making v1 design tokens the "default" values, and moving v0 values into the "opt-out" mode for Figma.

Updates build-style-dictionary script to now exclude any file with v0 (similar to how the original PR excluded any file with v1).

Copied v1 specific theming into sandbox/grommet-app so that deploy preview represents new theming.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: f1a24b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@taysea taysea requested a review from halocline February 5, 2025 00:29
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit b1a39b0
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/67a2b11b1d83a800086f3f18
😎 Deploy Preview https://deploy-preview-4766--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for rad-shortbread-897892 ready!

Name Link
🔨 Latest commit f1a24b3
🔍 Latest deploy log https://app.netlify.com/sites/rad-shortbread-897892/deploys/67a2b0d39f506e0008944e74
😎 Deploy Preview https://deploy-preview-4766--rad-shortbread-897892.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for rad-shortbread-897892 ready!

Name Link
🔨 Latest commit b1a39b0
🔍 Latest deploy log https://app.netlify.com/sites/rad-shortbread-897892/deploys/67a2b11bdb2851000875bc20
😎 Deploy Preview https://deploy-preview-4766--rad-shortbread-897892.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taysea taysea merged commit 1c39846 into master Feb 5, 2025
15 of 16 checks passed
@taysea taysea deleted the swap-default-mode branch February 5, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants