Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: trigger release processes when release workflow succeeded #47
release: trigger release processes when release workflow succeeded #47
Changes from all commits
939b99e
61d9a1b
999fb07
2171649
562c585
6884ce5
5e8fa4a
be6e11d
99af4b6
c9a8823
3c1b253
1a83b0a
f4f916f
7273386
752a436
7e7728f
d052250
9657fee
9224946
31fd835
2bb1a88
07b433e
bc59737
4a6812a
a548d2e
469ad67
764ce39
be34927
15cd16d
f3eecfd
a39c792
1481c70
b48457a
0be9ff2
2f40dc8
89dc83f
e0b7514
d94d95d
bceac4f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
よくわかってなくて初歩的な質問ですみません。
Error
をはさむときとRequestError < StandardError
するときとどういう違いがあるのですか?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubyは継承できるクラスが一つなので、今後拡張しやすいようにErrorのベースクラスは別で置いて置きたくて、このようにしてみました。(ただ、今回はまだ拡張予定が直近ではないのでなくても問題ないです。)