Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UNSURE to be UNCLEAR, catch __USURE received from the service #105

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update UNSURE to be UNCLEAR, catch __USURE received from the service #105

merged 1 commit into from
Oct 12, 2023

Conversation

brandon-groundlight
Copy link
Collaborator

Updates the labels displayed by the SDK to be YES, NO, and UNCLEAR

@brandon-groundlight brandon-groundlight marked this pull request as ready for review October 10, 2023 22:43
sunildkumar
sunildkumar approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@sunildkumar sunildkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, I think I would classify this as a breaking change to the SDK, as our customers are likely to be doing something with the string values we emit. So we probably need to do a version bump here. Otherwise it looks fine with me.

@brandon-groundlight
Copy link
Collaborator Author

Accidentally pushed some changes that belong to another commit here, hard reverted to the version Sunil reviewed

@brandon-groundlight brandon-groundlight changed the base branch from main to version_0.12.0 October 12, 2023 22:16
@brandon-groundlight brandon-groundlight merged commit 7c319b1 into version_0.12.0 Oct 12, 2023
14 of 15 checks passed
brandon-groundlight added a commit that referenced this pull request Oct 17, 2023
@sunildkumar @brandon-groundlight
Version 0.12.0 (#120)
bfac10f 
* bump version

* Update UNSURE to be UNCLEAR, catch __USURE received from the service (#105)

* ask_async (#102)

* initial commit

* added ask_async to submit_image_query

* Automatically reformatting code

* added ask async method

* Automatically reformatting code

* added integration tests (requires BE merge first)

* Automatically reformatting code

* satisfying mypy

* Automatically reformatting code

* fix comments

* change what type of exception test is catching

* Automatically reformatting code

* fix imports organization issue

* fix implementation - wait must be 0 not None

* Automatically reformatting code

* forgot to make wait=0 in relevant test

* feedback from PR review

* Automatically reformatting code

* ensure want_async is a serializable bool

* add description

* updated sphinx reqs to render some of the dependencies

* updated docstring for ask_async and fixed small sphinx bugs in other folk's docstrings

* Tests aren't passing because I didn't update the autogenerated code to expect a new param

* Revert "Tests aren't passing because I didn't update the autogenerated code to expect a new param"

This reverts commit 2477fd5.

* fix generated

* Automatically reformatting code

* fix lint

* Automatically reformatting code

* Revert "Automatically reformatting code"

This reverts commit cb9359e.

* Revert "fix generated"

This reverts commit 935c036.

* Revert "Revert "Tests aren't passing because I didn't update the autogenerated code to expect a new param""

This reverts commit 07670e3.

* Revert "Tests aren't passing because I didn't update the autogenerated code to expect a new param"

This reverts commit 2477fd5.

* Revert "updated docstring for ask_async and fixed small sphinx bugs in other folk's docstrings"

This reverts commit 67e3edd.

* third time at generated docs is the charm

---------

Co-authored-by: Auto-format Bot <[email protected]>

* Cli polishing (#109)

* Add basic catch if api token isn't specified when cli is called

* Pushes Groundlight class instantiation up until the function is actually called with arguments.
This means that the entire help args are available even if we can't instantiate the class (no api key)

* Fixed misunderstanding with metaprogramming, added tests

* Addressing comments

---------

Co-authored-by: Auto-format Bot <[email protected]>

* Add ask_confident and ask_ml (#99)

* Adding ask_confident and ask_fast

* Fixing ask_ml behavior

* Unhide wait functions, merging logic, fixed iq_is_answered logic

* Rewriting doc strings in Sphinx style

* fixed sphinx docstring return types

* Making iq submission with inspection work with newly optional patience time


---------

Co-authored-by: Auto-format Bot <[email protected]>

* Linting

* fix ask_async docstring

---------

Co-authored-by: brandon <[email protected]>
Co-authored-by: Brandon <[email protected]>
Co-authored-by: Auto-format Bot <[email protected]>
sunildkumar added a commit that referenced this pull request Oct 18, 2023
@sunildkumar @brandon-groundlight
@blaise-muhirwa @robotrapta
Ask_async docs (#113)
3360381 
* bump version

* Update UNSURE to be UNCLEAR, catch __USURE received from the service (#105)

* rough draft of demo

* ask_async (#102)

* initial commit

* added ask_async to submit_image_query

* Automatically reformatting code

* added ask async method

* Automatically reformatting code

* added integration tests (requires BE merge first)

* Automatically reformatting code

* satisfying mypy

* Automatically reformatting code

* fix comments

* change what type of exception test is catching

* Automatically reformatting code

* fix imports organization issue

* fix implementation - wait must be 0 not None

* Automatically reformatting code

* forgot to make wait=0 in relevant test

* feedback from PR review

* Automatically reformatting code

* ensure want_async is a serializable bool

* add description

* updated sphinx reqs to render some of the dependencies

* updated docstring for ask_async and fixed small sphinx bugs in other folk's docstrings

* Tests aren't passing because I didn't update the autogenerated code to expect a new param

* Revert "Tests aren't passing because I didn't update the autogenerated code to expect a new param"

This reverts commit 2477fd5.

* fix generated

* Automatically reformatting code

* fix lint

* Automatically reformatting code

* Revert "Automatically reformatting code"

This reverts commit cb9359e.

* Revert "fix generated"

This reverts commit 935c036.

* Revert "Revert "Tests aren't passing because I didn't update the autogenerated code to expect a new param""

This reverts commit 07670e3.

* Revert "Tests aren't passing because I didn't update the autogenerated code to expect a new param"

This reverts commit 2477fd5.

* Revert "updated docstring for ask_async and fixed small sphinx bugs in other folk's docstrings"

This reverts commit 67e3edd.

* third time at generated docs is the charm

* Automatically reformatting code

* finish making tests work

* Automatically reformatting code

---------

Co-authored-by: Auto-format Bot <[email protected]>

* Cli polishing (#109)

* Add basic catch if api token isn't specified when cli is called

* Pushes Groundlight class instantiation up until the function is actually called with arguments.
This means that the entire help args are available even if we can't instantiate the class (no api key)

* Fixed misunderstanding with metaprogramming, added tests

* Addressing comments

---------

Co-authored-by: Auto-format Bot <[email protected]>

* Add ask_confident and ask_ml (#99)

* Adding ask_confident and ask_fast

* Automatically reformatting code

* Fixing ask_ml behavior

* Adding to test

* Automatically reformatting code

* set default wait for ask_ml

* Unhide wait functions, merging logic, fixed iq_is_answered logic

* Automatically reformatting code

* Rewriting doc strings in Sphinx style

* ask_fast to ask_ml in the tests

* fixed sphinx docstring return types

* Cleaning the lint trap

* Last bits of lint

* Making iq submission with inspection work with newly optional patience time

* single char typo

* Reorder functions to trick Git's LCS alg to be correct

* Automatically reformatting code

---------

Co-authored-by: Auto-format Bot <[email protected]>

* Linting

* addressed self comments

* fix ask_async docstring

* small fixes

* cleaning up a bit

* Update docs/docs/building-applications/5-async-queries.md

Co-authored-by: blaise-muhirwa <[email protected]>

* Update docs/docs/building-applications/5-async-queries.md

Co-authored-by: robotrapta <[email protected]>

* small fixes based on PR feedback from Leo and Blaise

---------

Co-authored-by: brandon <[email protected]>
Co-authored-by: Brandon <[email protected]>
Co-authored-by: Auto-format Bot <[email protected]>
Co-authored-by: blaise-muhirwa <[email protected]>
Co-authored-by: robotrapta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunildkumar sunildkumar sunildkumar approved these changes

@mjvogelsong mjvogelsong Awaiting requested review from mjvogelsong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandon-groundlight @sunildkumar