Version 0.12.0 #120
Merged
Version 0.12.0 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * added ask_async to submit_image_query * Automatically reformatting code * added ask async method * Automatically reformatting code * added integration tests (requires BE merge first) * Automatically reformatting code * satisfying mypy * Automatically reformatting code * fix comments * change what type of exception test is catching * Automatically reformatting code * fix imports organization issue * fix implementation - wait must be 0 not None * Automatically reformatting code * forgot to make wait=0 in relevant test * feedback from PR review * Automatically reformatting code * ensure want_async is a serializable bool * add description * updated sphinx reqs to render some of the dependencies * updated docstring for ask_async and fixed small sphinx bugs in other folk's docstrings * Tests aren't passing because I didn't update the autogenerated code to expect a new param * Revert "Tests aren't passing because I didn't update the autogenerated code to expect a new param" This reverts commit 2477fd5. * fix generated * Automatically reformatting code * fix lint * Automatically reformatting code * Revert "Automatically reformatting code" This reverts commit cb9359e. * Revert "fix generated" This reverts commit 935c036. * Revert "Revert "Tests aren't passing because I didn't update the autogenerated code to expect a new param"" This reverts commit 07670e3. * Revert "Tests aren't passing because I didn't update the autogenerated code to expect a new param" This reverts commit 2477fd5. * Revert "updated docstring for ask_async and fixed small sphinx bugs in other folk's docstrings" This reverts commit 67e3edd. * third time at generated docs is the charm * Automatically reformatting code * finish making tests work * Automatically reformatting code --------- Co-authored-by: Auto-format Bot <[email protected]>
* Add basic catch if api token isn't specified when cli is called * Pushes Groundlight class instantiation up until the function is actually called with arguments. This means that the entire help args are available even if we can't instantiate the class (no api key) * Fixed misunderstanding with metaprogramming, added tests * Addressing comments --------- Co-authored-by: Auto-format Bot <[email protected]>
* Adding ask_confident and ask_fast * Automatically reformatting code * Fixing ask_ml behavior * Adding to test * Automatically reformatting code * set default wait for ask_ml * Unhide wait functions, merging logic, fixed iq_is_answered logic * Automatically reformatting code * Rewriting doc strings in Sphinx style * ask_fast to ask_ml in the tests * fixed sphinx docstring return types * Cleaning the lint trap * Last bits of lint * Making iq submission with inspection work with newly optional patience time * single char typo * Reorder functions to trick Git's LCS alg to be correct * Automatically reformatting code --------- Co-authored-by: Auto-format Bot <[email protected]>
sunildkumar
commented
Oct 17, 2023
Comment on lines
+362
to
+366
| if wait > 0: | ||
| if confidence_threshold is None: | ||
| threshold = self.get_detector(detector).confidence_threshold | ||
| else: | ||
| threshold = confidence_threshold |
There was a problem hiding this comment.
@brandon-groundlight why only query for confidence threshold for waits > 0? I guess to save time if the customer is trying to submit fast?
There was a problem hiding this comment.
The next line is in the if statement too. If wait is set to 0 (or less) then we're not going to make a call to wait_for_confident_result and since we don't make that call we don't need the threshold value.
sunildkumar
commented
Oct 17, 2023
| human_review: Optional[str] = None, | ||
| inspection_id: Optional[str] = None, | ||
| ) -> ImageQuery: | ||
| """ |
There was a problem hiding this comment.
It appears my example usage docstring disappeared...
There was a problem hiding this comment.
Looks like it's been added below!
brandon-groundlight
requested review from
mjvogelsong,
robotrapta,
blaise-muhirwa and
brandon-groundlight
brandon-groundlight
approved these changes
Oct 17, 2023
mjvogelsong
approved these changes
Oct 17, 2023
Comment on lines
+14
to
+18
| "[python]": { | ||
| "editor.codeActionsOnSave": { | ||
| "source.organizeImports": false | ||
| } | ||
| } |
There was a problem hiding this comment.
Why are we turning this off?
| @@ -48,6 +48,7 @@ sphinx-rtd-theme = {version = "1.3.0", python = ">=3.9.0,<4.0"} | |||
| autodoc-pydantic = {version = "2.0.1", python = ">=3.9.0,<4.0"} | |||
| pydantic = "^2.0" | |||
| toml = "0.10.2" | |||
| pillow = "^9.0.0" | |||
There was a problem hiding this comment.
Why is pillow needed for building sphinx docs?
Comment on lines
+408
to
+411
| - url: https://device.positronix.ai/device-api | ||
| description: Device Prod | ||
| - url: https://device.integ.positronix.ai/device-api | ||
| description: Device Integ |
There was a problem hiding this comment.
We can remove these -- they're old and deprecated.
| human_review: Optional[str] = None, | ||
| inspection_id: Optional[str] = None, | ||
| ) -> ImageQuery: | ||
| """ |
There was a problem hiding this comment.
Looks like it's been added below!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.