-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing default confidence threshold for new detectors from 0.9 to 0.75 #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot, changing the public-api.yaml is the reason we didn't do this sooner. This is fine, but this is the Absolute Last time that anyone should manually edit the public-api.yaml file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should bump us up to 0.16
pyproject.toml
Outdated
@@ -9,7 +9,7 @@ packages = [ | |||
{include = "**/*.py", from = "src"}, | |||
] | |||
readme = "README.md" | |||
version = "0.15.2" | |||
version = "0.15.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this classifies as a "breaking change" functionally speaking - in that client code will not behave the same after the change. So I think that means we should bump to 0.16.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Okay, at some point you'll need to teach me what the alternative is :) |
This PR changes default confidence threshold for new detectors from 0.9 to 0.75.
The rationale is:
I updated
public-api.yaml
and then ranmake generate
to update the necessary files, according to the instructions inDEVELOPING.md
.