Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter issues with __get__ #218

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

tyler-romero
Copy link
Member

@tyler-romero tyler-romero commented Jun 19, 2024

Ignore linter issue with get

@tyler-romero tyler-romero requested a review from robotrapta June 19, 2024 01:07
Copy link
Member

@robotrapta robotrapta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it back! This doesn't work!

Copy link
Member

@robotrapta robotrapta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant was "not approved"!

@tyler-romero tyler-romero force-pushed the tyler-romero-lint-patch-1 branch from f6c2383 to 28b246b Compare June 19, 2024 01:15
@tyler-romero
Copy link
Member Author

Ok, good that our tests failed here. I instead told the linter to ignore the supposed issue with __get__

Copy link
Member

@robotrapta robotrapta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that looks good.

@tyler-romero tyler-romero changed the title Update fix linter issues with __get__ Fix linter issues with __get__ Jun 19, 2024
@tyler-romero tyler-romero merged commit 9154ddc into main Jun 19, 2024
5 checks passed
@tyler-romero tyler-romero deleted the tyler-romero-lint-patch-1 branch June 19, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants