Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing reset test #248

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fixing reset test #248

merged 2 commits into from
Sep 5, 2024

Conversation

brandon-groundlight
Copy link
Collaborator

Human labels currently return with None confidence. Explains most of the current observations

@@ -28,7 +28,7 @@ def test_reset_retry(gl_experimental: ExperimentalApi):
def test_reset_training(gl_experimental: ExperimentalApi):
# If we reset a detector, we should have low confidence after the reset
low_confidence_threshold = 0.6
det = gl_experimental.get_or_create_detector("Test Detector for Resets", "is this a cat?")
det = gl_experimental.get_or_create_detector("Test Detector for Resets", "is this a cat?", confidence_threshold=0.5)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking no

@brandon-groundlight brandon-groundlight merged commit 99ed137 into main Sep 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants