Convert BDS 71 (parental birth country) from integer to string #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of the BDS field 71 is "alphanumeric". In
bdsreaderthis definition was interpreted that the data specification should be integer (pre-24.0) or numeric (24.0). Neither is correct. The usual interpretation is that BDS 71 is a string with four digits. For example, "0123" should be read into R as character, and not be converted to integer or number.This PR corrects this error. Changes made:
schemas/bds_v3.0.jsondefinition change (we don't care about pre v3.0 schemas)As a result definition and
blbfandblbmfields are now read as character.