Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-submit test validation action workflow #115

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Pre-submit test validation action workflow #115

merged 1 commit into from
Sep 7, 2022

Conversation

dennycd
Copy link
Contributor

@dennycd dennycd commented Sep 7, 2022 •
edited
Loading

Adding presubmit PR test workflow, triggered on PR open/updated for main branch.

  • SPM build test
    • lightweight build test with Swift Package Manager build. This provides coverages for any build break we may have encountered for SPM build & release.

SPM Build Test Clean Up

  • removed redundant test / uitest that is not used
  • temporarily suppress warning as error until next grpc native source sync (grpc-ios#83)

cc @HannahShiSFB

@dennycd dennycd added kind/test Test coverage area/spm Swift Package Manager Support labels Sep 7, 2022
@dennycd dennycd enabled auto-merge (squash) September 7, 2022 22:12
sampajano
sampajano approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool :)

@dennycd dennycd merged commit ddd9907 into grpc:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampajano sampajano sampajano approved these changes

@HannahShiSFB HannahShiSFB Awaiting requested review from HannahShiSFB

Assignees
No one assigned
Labels
area/spm Swift Package Manager Support kind/test Test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennycd @sampajano