Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support CIDR blocks in no_proxy env variable #2876
fix: support CIDR blocks in no_proxy env variable #2876
Changes from 1 commit
ca07343
ef510d9
2fa8861
5f20dc9
5e7cd85
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case where a non-IP
serverHost
string is passed toisIpInCIDR
is not explicitly handled, making the result unclear. Either this line should avoid making that call, orisIpInCIDR
should short-circuit returnfalse
if theserverHost
is not an IP address, oripToInt
should return an error value ifip
is not an IP address andisIpInCIDR
should check for that value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original logic uses
host === serverHost
to check for matches. That has been replaced here withserverHost.endsWith(host)
. That change is not related to supporting CIDR ranges, so it should be reverted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original logic where we handle single IPs is handled by
isIpInCIDR(parsedCIDR, serverHost)
as this latter transforms single IPs to CIDR notations (here).This
serverHost.endsWith(host)
was to support the case where we include domain names/suffixes in the NO_PROXY (for exampleNO_PROXY=example.com,.local.,.local.
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case wasn't stated in the issue, I'll update it and make sure it's well handled in the code. Thank you for raising this 🙇