-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile for grumpy
#151
base: master
Are you sure you want to change the base?
Conversation
You can take a look on the .travis.yaml describing the CI test. You may need to run the following lines on the Dockerfile to produce a working image: Lines 28 to 52 in 9c8d500
After that, the |
I see there is only one script in |
This could be done the two packages got independent. But they are coupled to a point that a split CI seemed not wise at the time. Having such names was the way I got to be able to use a monorepo for both packages. The proposed change will lead to deep changes on the package management & CI involving makefiles and Golang compilation. I do not recommend doing so, but feel free to mark me for code review or ask for references on setuptools internals :) |
@alanjds the directory structure already diverged between two |
Saving commands I use to build the image.
|
At least
|
Everything installs without error, but running fails.
|
@alanjds pushed latest version to Docker Hub. Should work now. |
It is Ubuntu 20.04 with Python 2. Still not clear how to run `grumpy` directly from source. /app/grumpy-tools-src# python2 grumpy_tools /usr/bin/python2: can't find '__main__' module in 'grumpy_tools' Need some helper scripts.
Python 2 `pip` is not packaged for 20.04
59ce94e
to
3a566e9
Compare
It is Ubuntu 20.04 with Python 2. Still not clear
how to run
grumpy
directly from source.Need some helper scripts.
Test that the image works.