Skip to content

Commit

Permalink
Removed/updated some TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
grunt-lucas committed Sep 15, 2024
1 parent e2d46bf commit 444cca0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions include/types.h
Original file line number Diff line number Diff line change
Expand Up @@ -644,11 +644,11 @@ enum class AssignAlgorithm { DFS, BFS };
enum class DecompilerMode { PRIMARY, SECONDARY };

/*
* TODO 1.0.0 : combine CompilerMode and DecompilerMode into a single type: CompilationMode ?
* TODO : combine CompilerMode and DecompilerMode into a single type: CompilationMode ?
*/

/*
* TODO 1.0.0 : Remove all checks against Subcommand type in the codebase, prefer explicit CompilationMode parameters
* TODO : Remove all checks against Subcommand type in the codebase, prefer explicit CompilationMode parameters
*/

std::string subcommandString(Subcommand subcommand);
Expand Down
2 changes: 1 addition & 1 deletion src/cli_parser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ static void parseSubcommandOptions(PorytilesContext &ctx, int argc, char *const
ctx.decompilerConfig.normalizeTransparencyColor = parseRgbColor(ctx.err, NORMALIZE_TRANSPARENCY, optarg);
}
else {
// TODO 1.0.0 : remove this deprecation warning
// TODO : remove this deprecation warning at some point in the future
pt_warn("the no-arg version of `normalize-transparency' has been deprecated");
pt_println(stderr,
" It is now the default Porytiles behavior, so you no longer need to specify this option.");
Expand Down
2 changes: 0 additions & 2 deletions src/driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,6 @@ static void driveDecompilePrimary(PorytilesContext &ctx)
/*
* Import behavior header, if it was supplied
*/
// TODO 1.0.0 : better error message if file did not exist? see compile version
auto [behaviorMap, behaviorReverseMap] =
prepareBehaviorsHeaderForImport(ctx, DecompilerMode::PRIMARY, ctx.decompilerSrcPaths.metatileBehaviors);

Expand All @@ -755,7 +754,6 @@ static void driveDecompileSecondary(PorytilesContext &ctx)
/*
* Import behavior header, if it was supplied
*/
// TODO 1.0.0 : better error message if file did not exist? see compile version
auto [behaviorMap, behaviorReverseMap] =
prepareBehaviorsHeaderForImport(ctx, DecompilerMode::SECONDARY, ctx.decompilerSrcPaths.metatileBehaviors);

Expand Down

0 comments on commit 444cca0

Please sign in to comment.