Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17
The MemoryManager is useful when it comes to testing or abstracting operations that require both
OffsetPageTable
andBootInfoFrameAllocator
.But registering it as singleton hidden behind
Once<Mutex<..>>
may be not very convenient.In future we will need
MemoryManager
insidealloc
module or any other module that handles heap allocation.Saying so there will be no reason to use
MemoryManager
outside ofalloc
module. So we can passMemoryManager
directly to that module and provideOnce<Mutex<MemoryManager>>
only for test purposes (by using#[cfg]
attribute).Feel free to provide your feedback.