Generalize the building of eduPersonEntitlement #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-luna-valero
added a commit
to sebastian-luna-valero/tosca-upv
that referenced
this pull request
Sep 5, 2024
sebastian-luna-valero
added a commit
to EGI-Federation/fedcloud-dashboard
that referenced
this pull request
Sep 5, 2024
enolfc
pushed a commit
to EGI-Federation/fedcloud-dashboard
that referenced
this pull request
Sep 19, 2024
* enable access via ssh-oidc and cloud.egi.eu * Replace ssh_oidc_other_vos with ssh_oidc_other_vos_name after grycap/ansible-role-motley-cue#13 * sudo powers for members of the vo.cloud.egi.eu with the auditor role * update CONTRIBUTING.md with latest version in the template * fix role name * linting * linting * fix grycap.motley_cue name * pass access token to Ansible playbook * use prettier to lint .github/workflows/deploy.yaml * add PWD to PATH * linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the construction of the
eduPersonEntitlementis mostly harcoded:ansible-role-motley-cue/tasks/main.yml
Lines 79 to 82 in 950d21a
This PR adds the changes required to make it configurable with Ansible variables.
Additionally, the
createsargument when executingcontextualise_ssh_serverhas been deleted:ansible-role-motley-cue/tasks/main.yml
Line 105 in 950d21a
Otherwise, updating the value of the variables for the configuration of the VO won't be applied to
motley_cue.confafter it has been created for the first time.Instead of
ssh_oidc_other_vos_*variables, we may also want to consider a shorter option for the naming.