Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation of nvidia drivers #124

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

sebastian-luna-valero
Copy link
Contributor

Hi,

Using https://github.com/grycap/tosca/blob/main/templates/nvidia.yml

I get this on a deployment:

[...]

 2024-03-19 13:52:20.468044: Galaxy role NVIDIA.nvidia_driver detected setting to install.

[...]

Install NVIDIA.nvidia_driver with ansible-galaxy.
Galaxy depencies file: [{src: NVIDIA.nvidia_driver}]

[...]

Launch task: nvidia_simple_node_conf_simple_node
Call Ansible
ERROR: the role 'nvidia.nvidia_driver' was not found in /var/tmp/.im/67a67798-e5f7-11ee-babd-f6a1a1a9232e/roles:/etc/ansible/roles:/var/tmp/.im/67a67798-e5f7-11ee-babd-f6a1a1a9232e

The error appears to be in '/var/tmp/.im/67a67798-e5f7-11ee-babd-f6a1a1a9232e/nvidia_simple_node_conf_simple_node_task.yml': line 6, column 5, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

roles:
- role: nvidia.nvidia_driver
^ here

ERROR executing playbook (1/1)

I think this may be due to the use of upper case characters?

file: NVIDIA.nvidia_driver

Instead of lower case?
https://galaxy.ansible.com/ui/standalone/roles/nvidia/nvidia_driver/

Please test this PR to check whether it works.

I am also explicitly passing the variable nvidia_driver_branch to the Ansible role, is this not needed?

Thanks,
Sebastian

@micafer
Copy link
Member

micafer commented Mar 20, 2024

You are rigth with the uppercase problem, but the variable is not needed, in fact this causes an error in ansible.
If you remove the variable addition I can accept the PR.

@sebastian-luna-valero
Copy link
Contributor Author

Done, thanks!

Copy link
Member

@micafer micafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micafer micafer merged commit f2345fd into grycap:main Mar 20, 2024
2 checks passed
@micafer
Copy link
Member

micafer commented Mar 20, 2024

updated in both instances of IM

@sebastian-luna-valero
Copy link
Contributor Author

Thank you very much!

@sebastian-luna-valero sebastian-luna-valero deleted the nvidia branch March 20, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants