Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AsciiDoc View-Mode by TextConverter with asciidoctor.js #2022

Merged
merged 8 commits into from
May 11, 2023
Merged

Support AsciiDoc View-Mode by TextConverter with asciidoctor.js #2022

merged 8 commits into from
May 11, 2023

Conversation

TimReset
Copy link
Contributor

Hi.

I added supporting asciidoctor.js to view adoc file.

I added 2 files:
asciidoctor.css
asciidoctor.min.js

@TimReset
issue 1880
dc68653 
Support asciidoctor.js. Support utf8 symbols.
@TimReset
issue 1880
a41d433 
Support asciidoctor.js. Support utf8 symbols.
@TimReset
issue 1880
5e70609 
Support asciidoctor.js. Support utf8 symbols.
@TimReset TimReset mentioned this pull request Apr 15, 2023
Closed
4 tasks
@gsantner gsantner linked an issue Apr 16, 2023 that may be closed by this pull request
View-Mode: AsciiDoc convert support #1880
Closed
4 tasks
@gsantner gsantner changed the title Support asciidoctor.js. Support AsciiDoc View-Mode by TextConverter with asciidoctor.js Apr 16, 2023
@gsantner
Copy link
Owner

@TimReset
Can you please add a license notice for the new added files? There is a licenses_3rd_party file which contains such licenses and is also possible to lookup while Markor is running.

@TimReset
Copy link
Contributor Author

@gsantner
done

@lrq3000 lrq3000 mentioned this pull request May 4, 2023
Closed
7 tasks
@gsantner gsantner added this to the Markor v2.11 milestone May 11, 2023
gsantner
gsantner approved these changes May 11, 2023
View reviewed changes
Copy link
Owner

@gsantner gsantner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes:

  • Exporting more or less is broken with asciidoc, due how it's currently implemented
  • The asciidoc sample document is mostly broken / doesn't contain much asciidoc syntax elements. Guess the images needs to be fixed so it works properly. But for missing "good" asciidoc sample, it's not in scope of the PR

Thanks, merging 🎉

@gsantner gsantner merged commit 3877c3d into gsantner:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsantner gsantner gsantner approved these changes

Assignees

@TimReset TimReset

Labels
feature
Projects
None yet
Milestone
Markor v2.11
Development

Successfully merging this pull request may close these issues.

View-Mode: AsciiDoc convert support
2 participants
@TimReset @gsantner