New Time Picker Component for Recurring Events #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I fixed the bug with a hacky fix but the design of the new component is a little sus. We can try and refactor. |
samarth52
changed the base branch from
bog-changes-s23
to
bog-changes-s23-merged
### Summary Resolves #269 Refactored code to improve code quality, removed redundant states and unnecessary useEffects, adding memorization ### Checklist - [x] look at the old code in Nathan's PR here - #240 - [x] Refactor it and improve code quality (state, useEffect, CSS) as you see fit. Some ideas - redundant state, unncessary useEffect - [x] If time permits look over how gt-scheduler loads data. Start reading at components/AppDataLoader. ### How to Test Test adding recurring events on Scheduler
yatharth-b
added a commit
that referenced
this pull request
Feb 4, 2024
This reverts commit ae32720.
yatharth-b
added a commit
that referenced
this pull request
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #230
Custom time picker component for recurring events.