Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept piped input #19

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Accept piped input #19

merged 1 commit into from
Mar 20, 2018

Conversation

kblum
Copy link
Contributor

@kblum kblum commented Oct 19, 2016

This pull request makes it possible to generate QR Codes by piping data to the CLI tool.

Accepting input as argument (standard usage):

./bin/qrcode-terminal.js 'http://github.com'

qrcode-terminal-argument

Accepting piped input:

echo 'http://github.com' | ./bin/qrcode-terminal.js

qrcode-terminal-pipe

Fixes #18

@siddhartpai
Copy link

This is a great pull request, @gtanner Can you please merge this off and release a better version of qr-code terminal

@mwbrooks
Copy link
Collaborator

Hey @kblum and @siddhartpai, I think this PR looks great as well. Works locally and tests all pass.

I still have commit and npm access, so I'll cut a release for you!

@mwbrooks mwbrooks merged commit 5232c3d into gtanner:master Mar 20, 2018
@mwbrooks
Copy link
Collaborator

Published on npm as [email protected]
https://www.npmjs.com/package/qrcode-terminal

Thanks again @kblum 💯

@gtanner
Copy link
Owner

gtanner commented Mar 20, 2018 via email

Cansiny0320 pushed a commit to Cansiny0320/qrcode-terminal that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants