Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix license to be valid SPDX #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mojoaxel
Copy link

This changes the license to a be a correct SPDX type. Currently the package.json is invalid.

The npm docs clearly state that a "licenses array" is (no longer?) valid:

// Not valid metadata
{
  "licenses" : [
    {
      "type": "MIT",
      "url": "https://www.opensource.org/licenses/mit-license.php"
    },
    {
      "type": "Apache-2.0",
      "url": "https://opensource.org/licenses/apache2.0.php"
    }
  ]
}

@yeldiRium
Copy link

Bumping this PR, since the invalid SPDX expression makes license compatibility checks harder than necessary.

@sethidden
Copy link

sethidden commented Aug 2, 2023

@gtanner Would you mind please taking a look? :) The "Apache 2.0" in the license field isn't a valid SPDX identifier because it's missing a dash https://spdx.org/licenses/Apache-2.0.html.

The missing dash makes license compliance scanning of dependencies troublesome. Most people will have Apache-2.0 on their allowed licenses list, but "Apache 2.0" with no dash is unexpected

sethidden added a commit to vuestorefront/engineering-toolkit that referenced this pull request Aug 2, 2023
sethidden added a commit to vuestorefront/engineering-toolkit that referenced this pull request Aug 2, 2023
sethidden added a commit to vuestorefront/engineering-toolkit that referenced this pull request Aug 2, 2023
sethidden added a commit to vuestorefront/engineering-toolkit that referenced this pull request Aug 2, 2023
sethidden added a commit to vuestorefront/engineering-toolkit that referenced this pull request Aug 2, 2023
@xjunior
Copy link

xjunior commented Aug 15, 2023

Good morning. Thanks for the good job on qacode-terminal. Any chance this could be fixed soon? As @yeldiRium said:

the invalid SPDX expression makes license compatibility checks harder than necessary.

sethidden added a commit to vuestorefront/vue-storefront that referenced this pull request Apr 5, 2024
sethidden added a commit to vuestorefront/vue-storefront that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants