Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CropSpec metadata can handle optional non String values #4347

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CropSpec metadata can handle optional non String values #4347

wants to merge 4 commits into from
+116 −42

Commits on Nov 29, 2024

  1. Refactor; extract the mapping of Crops to metadata and back. 

    To allow testing.
    @tonytw1
    tonytw1 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    32e4b11 View commit details
    Browse the repository at this point in the history

  2. Initial testing for crop spec metadata; CropSpec and Crop fields seem… 

    … to handle None inputs to metadata differently!

Not sure if this is intentional.
    @tonytw1
    tonytw1 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    14fa02b View commit details
    Browse the repository at this point in the history

  3. Fixes literal 'None' encoding of some empty Crop fields. 

    Treat all fields the same way then explicitly filter out None fields to protect ourselves from any misunderstandings about how collect treats values of type Option.
    @tonytw1
    tonytw1 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d294f9e View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Accept suggested improvement 

    Co-authored-by: Andrew Nowak <[email protected]>
    @tonytw1 @andrew-nowak
    tonytw1 and andrew-nowak authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    851926c View commit details
    Browse the repository at this point in the history