Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include setup-scala step in CI #126

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Include setup-scala step in CI #126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a589f
Include setup-scala step in CI
kelvin-chappell Dec 20, 2024
034508b
Use Java 11 to minimise the change.
kelvin-chappell Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,7 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Setup JDK
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 11
cache: sbt
- uses: guardian/setup-scala@v1
- name: Build and Test
env:
PROUT_GITHUB_ACCESS_TOKEN: ${{ secrets.PROUT_GITHUB_ACCESS_TOKEN }}
Expand Down
1 change: 1 addition & 0 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
java corretto-21.0.5.11.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using Java 11 with actions/setup-java. Here we're using Java 21. Have we tested with this version?

Copy link
Member Author

@kelvin-chappell kelvin-chappell Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment process here is a bit mysterious and I don't know what version of Java it uses. I have only tested the CI workflow. I'll set the version to 11 to keep this as an atomic change.

Loading