Fix/ios codegen doesnt work #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guhungry
force-pushed
the
Fix/ios-codegen-doesnt-work
branch
from
873e04a to
be12c2c
Compare
guhungry
force-pushed
the
Fix/ios-codegen-doesnt-work
branch
2 times, most recently
from
a4dab5e to
cd1f64b
Compare
set speed: 80 and timeout: 60000 for first element set speed: 60 everywhere else set visibilityPercentage: 60 everywhere
guhungry
force-pushed
the
Fix/ios-codegen-doesnt-work
branch
from
cd1f64b to
b8412a5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codegen doesn't find library so when new architecture is enabled it will build fail as in #942
For solution we can add export package.json as described in callstack/react-native-builder-bob#637