Feat: Add authentication for the test report page #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marius-williams
changed the title
marius-williams
changed the title
A few things we need to address:
{
"appID-a": ["read", "write"],
"appID-b": ["read"],
"appID-c": ["admin"],
"admin": ["admin"](A special case for someone who can perform CRUD on any app that reports using Fern),
}
|
jjchambl
reviewed
May 14, 2024
main.go
Outdated
Comment on lines
42
to
48
|
|
||
| authConfig := config.GetAuth() | ||
| if err := auth.UpdateJWKS(authConfig.KeysEndpoint); err != nil { | ||
| log.Fatalf("error getting JWKs: %v", err) | ||
| } | ||
| router.Use(auth.JWTAuthMiddleware(authConfig.KeysEndpoint)) | ||
| router.Use(cors.New(cors.Config{ |
There was a problem hiding this comment.
Does this fail if the user doesn't provide an endpoint?
There was a problem hiding this comment.
If so, how can local testing be done? This would make the product exclusively tied to OAuth.
There was a problem hiding this comment.
We probably need to set an env variable through which we can disable OAuth? or @bsekar is there a better way to do integration and acceptance tests?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
marius-williams
commented
May 15, 2024
pkg/auth/middleware_test.go
Outdated
Comment on lines
35
to
48
| ghttp.RespondWithJSONEncoded(http.StatusOK, map[string]interface{}{ | ||
| "keys": []interface{}{ | ||
| map[string]interface{}{ | ||
| "kty": "RSA", | ||
| "alg": "RS256", | ||
| "kid": "mAMF03ZNwGBz54bjNJLGtlTC9oP8zJSLrpkfBIH1R-E", | ||
| "use": "sig", | ||
| "e": "AQAB", | ||
| "n": "2uCExuw6kt86vt28clwQ8d0C1UHMUFUbBlthwiOpTTQYkFSbBUQKBJ16P9pnBrVwVr6-s1-84SKGnJnK6EX6IuiTKJQeEurV67ivoahtZXFBk02fBWd8LrkmDdCE59EsVB8zmHycYMCjm133n1THXjcpjQXKHWmTr3D7mP0jgGZWSdxTgGuWbglX5_OhqEZy7LNQQQYwBnGTsBxCm9Fr6g9b_dWz7l_pXpuVuaesMhL7zahwwCBE6d-tpcN_jhujTT6UhRB63uQsehchAot1BWNdBRsOtQtt4OW9EGqUD8ebVtAt8wchRi6wjCva9MLXQQNWehQftSTRqHZ8HNIOsw", | ||
| }, | ||
| }, | ||
| }), | ||
| ), | ||
| ) |
There was a problem hiding this comment.
It would be cleaner to use the JWK struct here, instead of map[string]interface{} inline.
There was a problem hiding this comment.
This was changed in the refactor.
anoop2811
reviewed
May 18, 2024
main.go
Outdated
Comment on lines
42
to
48
|
|
||
| authConfig := config.GetAuth() | ||
| if err := auth.UpdateJWKS(authConfig.KeysEndpoint); err != nil { | ||
| log.Fatalf("error getting JWKs: %v", err) | ||
| } | ||
| router.Use(auth.JWTAuthMiddleware(authConfig.KeysEndpoint)) | ||
| router.Use(cors.New(cors.Config{ |
There was a problem hiding this comment.
We probably need to set an env variable through which we can disable OAuth? or @bsekar is there a better way to do integration and acceptance tests?
fvarg00
reviewed
May 21, 2024
fvarg00
reviewed
May 21, 2024
fvarg00
reviewed
May 21, 2024
fvarg00
reviewed
May 21, 2024
fvarg00
reviewed
May 21, 2024
fvarg00
reviewed
May 21, 2024
fvarg00
requested changes
May 21, 2024
marius-williams
force-pushed
the
feat/auth
branch
from
d5e9202 to
1e021d5
Compare
marius-williams
force-pushed
the
feat/auth
branch
from
1e021d5 to
4975baa
Compare
- Fix other lint issues Signed-off-by: Anoop Gopalakrishnan <[email protected]>
fvarg00
reviewed
Jun 26, 2024
main.go
Outdated
| if _, err := jwksCache.Refresh(ctx, authConfig.JSONWebKeysEndpoint); err != nil { | ||
| log.Fatalf("URL is not a valid JWKS: %v", err) | ||
| } | ||
| fmt.Println("JWKS cache initialized and refreshed") |
There was a problem hiding this comment.
Use log.info instead of fmt.Println ?
There was a problem hiding this comment.
This is outdated. This is no longer in main.go
…pe claim matches the caller.
…r readability. Updated tests.
fvarg00
approved these changes
Jul 2, 2024
|
Good work @marius-williams ! |
Thank you @anoop2811 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Fern Auth
Description:
This pull request introduces authentication functionalities to fern. This is made possible by using the middleware functionality of the Gin framework to intercept all API calls and perform JWT validation using JWKS.
Changes Included: