Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update example with realistic annotation using the '.' character. #48

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

jamesdobson
Copy link
Collaborator

No description provided.

Copy link
Contributor

➡️ Go test coverage stayed the same at 70.9% compared to 200f667 (1 ignored files)
⚠️ 2 of 12 packages have zero coverage.
  • kumquat
  • kumquat/cmd

No change in coverage for any package.

View coverage for all packages
# Package Name                | Coverage
- kumquat                     |     0.0%
+ kumquat/api/v1beta1         |   100.0%
- kumquat/cmd                 |     0.0%
+ kumquat/internal/controller |    71.7%
+ kumquat/renderer            |   100.0%
+ kumquat/renderer/cue        |    87.5%
+ kumquat/renderer/gotemplate |    95.8%
+ kumquat/renderer/jsonnet    |    87.9%
+ kumquat/repository          |    91.8%
+ kumquat/store               |    75.0%
+ kumquat/template            |    93.9%
+ kumquat/test/utils          |    10.8%

@jamesdobson
Copy link
Collaborator Author

I wanted a more realistic annotation that contains the . character.

This turned out to be a bit tricky because the . character is the key separator for json_extract() paths, and it doesn't say in the SQLite reference how to quote it.

Now that we are using it in an example, it will hopefully help some users in the future.

@jamesdobson jamesdobson merged commit 89ce804 into main Nov 16, 2024
4 checks passed
@jamesdobson jamesdobson deleted the docs/improve-example-with-annotation branch November 16, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants