Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In addition to Date, Open, High, Low, Close, Volume, Market Cap, the … #63

Merged
merged 1 commit into from
Oct 13, 2023
Merged

In addition to Date, Open, High, Low, Close, Volume, Market Cap, the … #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

All notable changes to this project will be documented in this file.

## [0.6.4] - 2023-10-14

### Added

- In addition to Date, Open, High, Low, Close, Volume, Market Cap, the following time columns are returned: Time Open, Time High, Time Low, Time Close.

## [0.6.3] - 2023-07-22

### Added
Expand Down
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ To get data of a cryptocurrency for some days

Following are the columns of the data
"""""""""""""""""""""""""""""""""""""
``Date, Open, High, Low, Close, Volume, Market Cap``
``Date, Open, High, Low, Close, Volume, Market Cap, Time Open, Time High, Time Low, Time Close``


Acknowledgements
Expand Down
6 changes: 5 additions & 1 deletion cryptocmd/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def __init__(
self.order_ascending = order_ascending
self.fiat = fiat
self.coin_name = coin_name
self.headers = ["Date", "Open", "High", "Low", "Close", "Volume", "Market Cap"]
self.headers = ["Date", "Open", "High", "Low", "Close", "Volume", "Market Cap", "Time Open", "Time High", "Time Low", "Time Close"]
self.rows = []
self.id_number = id_number

Expand Down Expand Up @@ -108,6 +108,10 @@ def _download_data(self, **kwargs):
_row_quote["close"],
_row_quote["volume"],
_row_quote["market_cap"],
_row["time_open"],
_row["time_high"],
_row["time_low"],
_row["time_close"],
]

self.rows.insert(0, row)
Expand Down