Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type checking as part of tests #53

Open
thiskappaisgrey opened this issue May 1, 2024 · 1 comment
Open

Add type checking as part of tests #53

thiskappaisgrey opened this issue May 1, 2024 · 1 comment

Comments

@thiskappaisgrey
Copy link
Collaborator

Recently, a commit broke something (see: #51 ) broke something that could've been caught if the tests also ran typechecking.

Please also run typechecking as part of tests - to make sure that new commits don't break anything. Thanks.
@gussmith23
Copy link
Owner

Agree, this would be very helpful! Will push it on the queue, but no promises on when it will get done. Feel free to put up a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gussmith23 @thiskappaisgrey