Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to delete Wire exprs in generated egglog commands? #93

Open
gussmith23 opened this issue Jul 28, 2024 · 0 comments
Open

Do we want to delete Wire exprs in generated egglog commands? #93

gussmith23 opened this issue Jul 28, 2024 · 0 comments

Comments

@gussmith23
Copy link
Owner

Related to #92.

Sometimes Wire expressions don't actually end up unioned with anything. E.g. if we have an unused port on a module connected to a placeholder Wire. We don't necessarily want to delete that Wire, because it is in fact useful!

We can likely detect at egglog codegen time whether we can delete a wire or not. If it's been unioned with something, delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant