Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robust json parsing & entity extraction progress log #55

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

rangehow
Copy link
Collaborator

  1. The JSON generated by large models may have issues such as being incomplete, redundant, or having formatting errors. The original solution was too brief and provided few prompts, so we made some improvements to address these.
  2. Entity extraction is the most time-consuming part of this project, but there was no explicit progress indicator. We added a percentage indicator to let users know the current progress more clearly.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.25%. Comparing base (1a85851) to head (ba3b2be).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
nano_graphrag/_utils.py 90.56% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          12       12           
  Lines        1288     1288           
=======================================
  Hits         1214     1214           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NazimHAli
Copy link

NazimHAli commented Oct 15, 2024

I didn't see this PR until now, yesterday I ended up adding tqdm to every task so that all the progress bars were available by default. Happy to help with this if needed 👍

@rangehow
Copy link
Collaborator Author

I didn't see this PR until now, yesterday I ended up adding tqdm to every task so that all the progress bars were available by default. Happy to help with this if needed.

Hi @NazimHAli. You can bring up a new PR, and I will reorganize the submitted code by removing the percentage related parts. But it's better to do it quickly, because tonight this PR will be merged.

@rangehow
Copy link
Collaborator Author

@gusye1234 cc

@rangehow rangehow closed this Oct 18, 2024
@rangehow rangehow reopened this Oct 18, 2024
@NazimHAli
Copy link

I didn't see this PR until now, yesterday I ended up adding tqdm to every task so that all the progress bars were available by default. Happy to help with this if needed.

Hi @NazimHAli. You can bring up a new PR, and I will reorganize the submitted code by removing the percentage related parts. But it's better to do it quickly, because tonight this PR will be merged.

I won't have time to do it before this gets merged. You can continue with this change and I can do a follow-up later.

@gusye1234 gusye1234 merged commit 50218fb into gusye1234:main Oct 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants