Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow shell history embedding unless explicitly configured #33

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

guywaldman
Copy link
Owner

@guywaldman guywaldman commented Jul 23, 2024

This PR:

  • Adds a new general.access_to_shell_history configuration flag for explicitly allowing access to shell history
  • Adds a new search.allow_remote_llm configuration flag for explicitly allowing access to shell history to non-local LLM providers
  • Adds a new search.shell_history configuration for specifying a custom path to a shell history file (added for testing, but may be optionally useful for users none the less)
  • Adds a new search.index_dir configuration for specifying a custom path to a directory which will contain the indexing data and metadata (added for testing, but may be optionally useful for users none the less)
  • Adds and improves on E2E test coverage
  • Fixes an issue where embeddings wouldn't work for OpenAI since embedding dimensions were provided and were throwing an error (see Remove dims for OpenAI orch#13)
  • Various fixes & enhancements

Addresses #30

@guywaldman guywaldman merged commit 126641e into main Jul 23, 2024
12 checks passed
@guywaldman guywaldman deleted the user/guywaldman/non-local-embeddings branch July 23, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant