Remove dims for OpenAI (#13)

guywaldman · Jul 23, 2024 · 4897936 · 4897936
1 parent d2eadf6
commit 4897936
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/core/src/lm/lm_provider/openai/builder.rs b/core/src/lm/lm_provider/openai/builder.rs
@@ -72,16 +72,10 @@ impl LanguageModelBuilder<OpenAi> for OpenAiBuilder {
                 "Embeddings model".to_string(),
             ));
         };
-        let Some(embedding_dimensions) = self.embedding_dimensions else {
-            return Err(LanguageModelBuilderError::ConfigurationNotSet(
-                "Embedding dimensions".to_string(),
-            ));
-        };
         Ok(OpenAi {
             api_key: api_key.to_owned(),
             model: model.to_owned(),
             embeddings_model: embeddings_model.to_owned(),
-            embedding_dimensions,
         })
     }
 }
diff --git a/core/src/lm/lm_provider/openai/lm.rs b/core/src/lm/lm_provider/openai/lm.rs
@@ -22,7 +22,6 @@ pub struct OpenAi {
     pub api_key: String,
     pub model: String,
     pub embeddings_model: String,
-    pub embedding_dimensions: usize,
 }
 
 #[derive(Error, Debug)]
@@ -112,7 +111,7 @@ impl LanguageModel for OpenAi {
             .embedding(EmbeddingRequest {
                 model: self.embeddings_model.to_owned(),
                 input: prompt.to_owned(),
-                dimensions: Some(self.embedding_dimensions as i32),
+                dimensions: None,
                 user: None,
             })
             .await