Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements #378

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Small improvements #378

merged 8 commits into from
Nov 7, 2024

Conversation

dbrakenhoff
Copy link
Collaborator

  • Load ds from binary model grid (e.g. model.disv.grb file)
  • Improve pyproj CRS initialization
  • Add get_area() method using shoelace formula
  • allow plotting modelgrid with or without rotation.

@dbrakenhoff
allow ds_time_to_pandas_index
7980f08 
to accept both ds.time and ds
@rubencalje
Copy link
Collaborator

Looks good. Would add_area_to_ds not be a better method name, instead of get_area?

@OnnoEbbens
Copy link
Collaborator

I think it is better to return the area and not add the area to the dataset. Like we do in get_idomain. Also discussed in this issue #254

@dbrakenhoff dbrakenhoff merged commit df4c918 into dev Nov 7, 2024
2 of 3 checks passed
@dbrakenhoff dbrakenhoff deleted the small_improvements branch November 7, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubencalje rubencalje rubencalje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbrakenhoff @rubencalje @OnnoEbbens