Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM Dependency Cleanup and Debian Install Script Fixes #25

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

bushidocodes
Copy link
Contributor

@bushidocodes bushidocodes commented Mar 24, 2021

Resolves #11

While working on some ARM stuff, I realized that some of the dependencies for this repo got a bit messed up back in July of last year. It seems like Phani was in the process of moving all transitive dependencies over to our gwsystems org with a clean master tracking upstream and an sfbase branch containing our downstream patches. It seems like a PR (Others/llvm-rs#1) got merged, which put things out of sync, and the effort sort of petered out. As a result, one repo contained the ARM fix and another repo contained some quality of life refactors. This PR is the result of my effort to get this straightened out such that gwsystems llvm-rs and llvm-sys repos now contain all existing work and can be considered the canonical dependencies and the equivalent repos under @Others account can be potentially archived.

The main contribution of this PR is updating the Cargo.toml to use the sfbranch of our gwsystems llvm-rs repo. This contains the following changes:

If you want to confirm this, I suggest checking out the following:

I also have a handful of BASH script cleanup tasks that I encountered when testing ARM stuff on a fresh Ubuntu install on a Pi 4:

  • Supporting SSH and HTTPS-based clones
  • Installing wget if missing
  • Not prefixing with sudo if root
  • Installing clang 11 in place of 9

@bushidocodes bushidocodes requested a review from Others March 24, 2021 02:01
Copy link
Contributor

@Others Others left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nervous about regressions, but approved for now

@bushidocodes
Copy link
Contributor Author

Going to go ahead and merge. I rebased the branch on top of the latest master and reran our tests again.

@bushidocodes bushidocodes merged commit fc9d17d into master Mar 26, 2021
@bushidocodes bushidocodes deleted the arm-cleanup branch March 26, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependancy on Others's repos
2 participants