Skip to content

Commit

Permalink
Mistakes in PredCorr in geometryRTheta
Browse files Browse the repository at this point in the history
A typo in the comment and mixing two advection fields in the `bs_predcorr_second_order_explicit.hpp` file.

See merge request gysela-developpers/gyselalibxx!739

--------------------------------------------
  • Loading branch information
PaulineVidal committed Oct 22, 2024
1 parent 441ff9b commit 843bfd6
Showing 1 changed file with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -133,17 +133,16 @@ class BslExplicitPredCorrRTheta : public ITimeSolverRTheta
}


~BslExplicitPredCorrRTheta() {};
~BslExplicitPredCorrRTheta() override {}



host_t<DFieldRTheta> operator()(
host_t<DFieldRTheta> allfdistribu,
double const dt,
int const steps) const
int const steps) const final
{
std::chrono::time_point<std::chrono::system_clock> start_time
= std::chrono::system_clock::now();
std::chrono::time_point<std::chrono::system_clock> start_time;
std::chrono::time_point<std::chrono::system_clock> end_time;

// Grid. ------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -223,7 +222,7 @@ class BslExplicitPredCorrRTheta : public ITimeSolverRTheta


// STEP 4: From rho^P, we compute phi^P: Poisson equation
m_builder(get_field(allfdistribu_coef), get_const_field(allfdistribu));
m_builder(get_field(allfdistribu_coef), get_const_field(allfdistribu_predicted));
PoissonLikeRHSFunction const
charge_density_coord_4(get_const_field(allfdistribu_coef), m_evaluator);
m_poisson_solver(charge_density_coord_4, electrostatic_potential_coef);
Expand All @@ -232,7 +231,7 @@ class BslExplicitPredCorrRTheta : public ITimeSolverRTheta
advection_field_computer(electrostatic_potential_coef, advection_field_predicted);


// --- we evaluate the advection field A^n at the characteristic feet X^Theta
// --- we evaluate the advection field A^n at the characteristic feet X^P
host_t<DVectorFieldMemRTheta<X, Y>> advection_field_evaluated(grid);
host_t<VectorSplineCoeffsMem2D<X, Y>> advection_field_coefs(
get_spline_idx_range(m_builder));
Expand Down

0 comments on commit 843bfd6

Please sign in to comment.