Resolve "Fix -Wpedantic warnings"

simulations/utilities/simulation_utils_tools.hpp

@@ -22,4 +22,4 @@ void display_time_difference(
             = std::chrono::duration_cast<std::chrono::milliseconds>(end_time - start_time).count();
     std::cout << title << time_h << "h " << time_min - time_h * 60 << "min "
               << time_s - time_min * 60 << "s " << time_ms - time_s * 1000 << "ms " << std::endl;
-};
+}

src/geometryXYVxVy/poisson/fftpoissonsolver.cpp

@@ -50,7 +50,7 @@ void FftPoissonSolver::operator()(
             fft(Kokkos::DefaultHostExecutionSpace(),
                 intermediate_chunk.span_view(),
                 rho.span_view(),
-                (ddc::kwArgs_fft) {.normalization = norm});
+                ddc::kwArgs_fft {norm});
 
     // Solve Poisson's equation -d2Phi/dx2 = rho
     //   in Fourier space as -kx*kx*FFT(Phi)=FFT(rho))
@@ -84,7 +84,7 @@ void FftPoissonSolver::operator()(
             ifft(Kokkos::DefaultHostExecutionSpace(),
                  electric_field_x.span_view(),
                  fourier_efield.span_view(),
-                 ddc::kwArgs_fft {.normalization = norm});
+                 ddc::kwArgs_fft {norm});
 
     // Calculate y component
     ddc::for_each(k_mesh, [&](IndexFxFy const ikxky) {
@@ -97,15 +97,15 @@ void FftPoissonSolver::operator()(
             ifft(Kokkos::DefaultHostExecutionSpace(),
                  electric_field_y.span_view(),
                  fourier_efield.span_view(),
-                 ddc::kwArgs_fft {.normalization = norm});
+                 ddc::kwArgs_fft {norm});
     Kokkos::Profiling::popRegion();
 
     // Perform the inverse 1D FFT of the solution to deduce the electrostatic potential
     ddc::
             ifft(Kokkos::DefaultHostExecutionSpace(),
                  electrostatic_potential.span_view(),
                  intermediate_chunk.span_view(),
-                 (ddc::kwArgs_fft) {.normalization = norm});
+                 ddc::kwArgs_fft {norm});
 
     Kokkos::Profiling::popRegion();
 }

src/timestepper/crank_nicolson.hpp

@@ -222,7 +222,7 @@ class CrankNicolson : public ITimeStepper
 
 
         } while (not_converged and (counter < m_max_counter));
-    };
+    }
 
 
     /**

src/timestepper/euler.hpp

@@ -147,5 +147,5 @@ class Euler : public ITimeStepper
         // ----------- Update y --------------
         // Calculate y_new := y_n + h*k_1
         y_update(y, m_k1, dt);
-    };
+    }
 };

src/timestepper/rk2.hpp

@@ -169,5 +169,5 @@ class RK2 : public ITimeStepper
         // ----------- Update y --------------
         // Calculate y_{n+1} := y_n + h*k_2
         y_update(y, m_k2, dt);
-    };
+    }
 };

src/timestepper/rk3.hpp

@@ -225,7 +225,7 @@ class RK3 : public ITimeStepper
 
         // Calculate y_{n+1} := y_n + (k1 + 4 * k2 + k3) * h/6
         y_update(y, m_k_total, dt / 6.);
-    };
+    }
 
 private:
     void copy(ValSpan copy_to, ValView copy_from) const

src/timestepper/rk4.hpp

@@ -218,7 +218,7 @@ class RK4 : public ITimeStepper
 
         // Calculate y_{n+1} := y_n + (k1 + 2 * k2 + 2 * k3 + k4) * h/6
         y_update(y, m_k_total, dt / 6.);
-    };
+    }
 
 private:
     void copy(ValSpan copy_to, ValView copy_from) const

src/utils/ddc_helper.hpp

@@ -104,7 +104,7 @@ restrict_to_domain(
         coord -= length;
     return coord;
 }
-}; // namespace ddcHelper
+} // namespace ddcHelper
 
 namespace detail {
 

src/utils/utils_tools.hpp

@@ -25,7 +25,7 @@ KOKKOS_FUNCTION double norm_inf(ddc::Coordinate<Tags...> coord)
     double result = 0.0;
     ((result = std::max(result, fabs(coord.template get<Tags>()))), ...);
     return result;
-};
+}
 
 
 /**
@@ -42,4 +42,4 @@ KOKKOS_FUNCTION double norm_inf(ddc::Coordinate<Tags...> coord)
 KOKKOS_FUNCTION inline double norm_inf(double const coord)
 {
     return coord;
-};
+}

src/utils/vector_field_common.hpp

@@ -60,7 +60,7 @@ inline constexpr typename ChunkType::view_type get(
 }
 
 
-}; // namespace ddcHelper
+} // namespace ddcHelper
 
 template <class ChunkType, class... DDims>
 class VectorFieldCommon<ChunkType, ddc::detail::TypeSeq<DDims...>>

tests/geometryRTheta/2d_spline_interpolator/2d_spline_interpolator.cpp

@@ -145,7 +145,7 @@ void Interpolation_on_random_coord(
     } else {
         std::cout << "  FAILED" << std::endl;
     }
-};
+}
 
 /**
  * @brief A class of function on polar coordinates.

tests/geometryRTheta/advection_2d_rp/advection_simulation_utils.hpp

@@ -126,7 +126,7 @@ void save_feet(
         file_feet << std::endl;
     });
     file_feet.close();
-};
+}
 
 
 /**

tests/utils/test_ddcHelpers.cpp

@@ -17,7 +17,7 @@ class Tag
 
 using Coord = Coordinate<Tag>;
 
-}; // namespace
+} // namespace
 
 TEST(DDCHelper, UniformPeriodicRestriction)
 {

vendor/sll/include/sll/constant_extrapolation_boundary_value.hpp

@@ -162,7 +162,9 @@ class ConstantExtrapolationBoundaryValue2D : public SplineBoundaryValue2D<BSplin
             coord_type_no_bc const eval_pos_no_bc_max)
         : m_eval_pos_bc(eval_pos_bc)
         , m_eval_pos_no_bc_min(eval_pos_no_bc_min)
-        , m_eval_pos_no_bc_max(eval_pos_no_bc_max) {};
+        , m_eval_pos_no_bc_max(eval_pos_no_bc_max)
+    {
+    }
 
     /**
      * @brief Instantiate a ConstantExtrapolationBoundaryValue2D with periodic splines
@@ -181,7 +183,9 @@ class ConstantExtrapolationBoundaryValue2D : public SplineBoundaryValue2D<BSplin
     explicit ConstantExtrapolationBoundaryValue2D(coord_type_bc const eval_pos_bc)
         : m_eval_pos_bc(eval_pos_bc)
         , m_eval_pos_no_bc_min(coord_type_no_bc(0.))
-        , m_eval_pos_no_bc_max(coord_type_no_bc(0.)) {};
+        , m_eval_pos_no_bc_max(coord_type_no_bc(0.))
+    {
+    }
 
 
     ~ConstantExtrapolationBoundaryValue2D() override = default;

vendor/sll/include/sll/mapping/circular_to_cartesian.hpp

@@ -254,7 +254,7 @@ class CircularToCartesian
     double to_pseudo_cartesian_jacobian_11_center(Domain const& grid) const
     {
         return 1.;
-    };
+    }
 
     /**
      * @brief Compute the (1,2) coefficient of the pseudo-Cartesian Jacobian matrix at the central point.
@@ -272,7 +272,7 @@ class CircularToCartesian
     double to_pseudo_cartesian_jacobian_12_center(Domain const& grid) const
     {
         return 0.;
-    };
+    }
 
     /**
      * @brief Compute the (2,1) coefficient of the pseudo-Cartesian Jacobian matrix at the central point.
@@ -290,7 +290,7 @@ class CircularToCartesian
     double to_pseudo_cartesian_jacobian_21_center(Domain const& grid) const
     {
         return 0.;
-    };
+    }
 
     /**
      * @brief Compute the (2,2) coefficient of the pseudo-Cartesian Jacobian matrix at the central point.
@@ -308,5 +308,5 @@ class CircularToCartesian
     double to_pseudo_cartesian_jacobian_22_center(Domain const& grid) const
     {
         return 1.;
-    };
+    }
 };

vendor/sll/tests/constant_extrapolation_bc.cpp

@@ -426,7 +426,7 @@ void Evaluate_on_outside_coord(IDomainRP const& grid, Function& exact_function,
 
     // Compare the obtained values with the exact function. ----------------------------------
     check_constant_outside_domain(function_evaluated, exact_function, coords, outside_coords, TOL);
-};
+}
 
 
 
@@ -499,7 +499,7 @@ void Evaluate_on_outside_coord(IDomainXY const& grid, Function& exact_function,
 
     // Compare the obtained values with the exact function. ----------------------------------
     check_constant_outside_domain(function_evaluated, exact_function, coords, outside_coords, TOL);
-};
+}
 
 
 

vendor/sll/tests/gauss_legendre_integration.cpp

@@ -91,7 +91,7 @@ int test_integrate()
     }
 
     return test_passed;
-};
+}
 
 /// This test integrates polynomials of the form x^p for p <= 2*order-1
 /// where order is the order of the GaussLegendre integration method.
@@ -168,7 +168,7 @@ int test_compute_points_and_weights()
     }
 
     return test_passed;
-};
+}
 
 TEST(GaussLegendre, IntegrateDouble)
 {