Skip to content

Commit

Permalink
Merge pull request #566 from h2o/kazuho/delivery-rate-on-dupack
Browse files Browse the repository at this point in the history
[delivery rate estimator] fix handling of dupack
  • Loading branch information
kazuho authored Nov 11, 2023
2 parents 5d330a5 + 136a291 commit 70034e5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/quicly.c
Original file line number Diff line number Diff line change
@@ -5340,8 +5340,9 @@ static int handle_ack_frame(quicly_conn_t *conn, struct st_quicly_handle_payload
QUICLY_PROBE(ACK_DELAY_RECEIVED, conn, conn->stash.now, frame.ack_delay);
QUICLY_LOG_CONN(ack_delay_received, conn, { PTLS_LOG_ELEMENT_UNSIGNED(ack_delay, frame.ack_delay); });

quicly_ratemeter_on_ack(&conn->egress.ratemeter, conn->stash.now, conn->super.stats.num_bytes.ack_received,
largest_newly_acked.pn);
if (largest_newly_acked.pn != UINT64_MAX)
quicly_ratemeter_on_ack(&conn->egress.ratemeter, conn->stash.now, conn->super.stats.num_bytes.ack_received,
largest_newly_acked.pn);

/* Update loss detection engine on ack. The function uses ack_delay only when the largest_newly_acked is also the largest acked
* so far. So, it does not matter if the ack_delay being passed in does not apply to the largest_newly_acked. */

0 comments on commit 70034e5

Please sign in to comment.