Merge pull request #572 from h2o/kazuho/fix-asan-crashes

fix asan crashes
h2o · Mar 14, 2024 · 8d5bef5 · 8d5bef5
2 parents 3336ce1 + 4c3fa98
commit 8d5bef5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,6 +29,10 @@ jobs:
     - uses: actions/checkout@v2
       with:
         submodules: recursive
+    - name: setup
+      run: |
+        sudo sysctl -w vm.mmap_rnd_bits=28 # new default is 32 that causes libasan crashes
+
     - name: Run with Docker
       shell: 'script -q -e -c "bash -xe {0}"'
       run: |

diff --git a/t/e2e.t b/t/e2e.t
@@ -455,7 +455,7 @@ sub spawn_process {
     }
     while (`netstat -na` !~ /^udp.*\s(127\.0\.0\.1|0\.0\.0\.0|\*)[\.:]$listen_port\s/m) {
         if (waitpid($pid, WNOHANG) == $pid) {
-            die "failed to launch @{[$cmd->[0]]}";
+            die "failed to launch @{[$cmd->[0]]}:$?";
         }
         sleep 0.1;
     }