for symmetry, emit payload in the stream_receive probe

h2o · Jan 29, 2025 · 9963836 · 9963836
1 parent f66446b
commit 9963836
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/quicly.c b/lib/quicly.c
@@ -2143,11 +2143,13 @@ static quicly_error_t apply_stream_frame(quicly_stream_t *stream, quicly_stream_
 {
     quicly_error_t ret;
 
-    QUICLY_PROBE(STREAM_RECEIVE, stream->conn, stream->conn->stash.now, stream, frame->offset, frame->data.len);
+    QUICLY_PROBE(STREAM_RECEIVE, stream->conn, stream->conn->stash.now, stream, frame->offset, frame->data.base, frame->data.len,
+                 frame->is_fin);
     QUICLY_LOG_CONN(stream_receive, stream->conn, {
         PTLS_LOG_ELEMENT_SIGNED(stream_id, stream->stream_id);
         PTLS_LOG_ELEMENT_UNSIGNED(off, frame->offset);
-        PTLS_LOG_ELEMENT_UNSIGNED(len, frame->data.len);
+        PTLS_LOG_APPDATA_ELEMENT_HEXDUMP(data, frame->data.base, frame->data.len);
+        PTLS_LOG_ELEMENT_BOOL(is_fin, frame->is_fin);
     });
 
     if (quicly_recvstate_transfer_complete(&stream->recvstate))

diff --git a/quicly-probes.d b/quicly-probes.d
@@ -90,7 +90,8 @@ provider quicly {
 
     probe stream_send(struct st_quicly_conn_t *conn, int64_t at, struct st_quicly_stream_t *stream, uint64_t off, const void *data,
                       size_t data_len, int is_fin, int wrote_all);
-    probe stream_receive(struct st_quicly_conn_t *conn, int64_t at, struct st_quicly_stream_t *stream, uint64_t off, size_t len);
+    probe stream_receive(struct st_quicly_conn_t *conn, int64_t at, struct st_quicly_stream_t *stream, uint64_t off,
+                         const void *data, size_t data_len, int is_fin);
     probe stream_acked(struct st_quicly_conn_t *conn, int64_t at, int64_t stream_id, uint64_t off, size_t len);
     probe stream_lost(struct st_quicly_conn_t *conn, int64_t at, int64_t stream_id, uint64_t off, size_t len);