Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow reconnects without losing state/focus. #2253

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented Feb 5, 2024

Demo (disconnect every 5s)

Screen.Recording.2024-02-05.at.10.10.08.AM.mov

Closes #2252

client.go Show resolved Hide resolved
socket.go Show resolved Hide resolved
Copy link

@codyharris-h2o-ai codyharris-h2o-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but it would be great if we could tune that reconnection window duration - 2s feels pretty short

client.go Outdated Show resolved Hide resolved
client.go Show resolved Hide resolved
socket.go Show resolved Hide resolved
Copy link
Contributor

@geomodular geomodular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Martin, good job!

@mturoci mturoci merged commit 26f3c73 into main Feb 7, 2024
2 checks passed
@mturoci mturoci deleted the feat/issue-2252 branch February 7, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Wave more resilient to unstable networks
3 participants