Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added second select #2416

Closed
wants to merge 5 commits into from
Closed

Conversation

akwaed
Copy link

@akwaed akwaed commented Oct 17, 2024

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Added name parameters to all applicable widgets
TODO: update doc description  to the affected types/members
Added seconds select in time picker and updated the testing to be in format
@akwaed akwaed closed this Oct 17, 2024
@akwaed akwaed reopened this Oct 17, 2024
@akwaed akwaed changed the title Added second select Feat: Added second select Oct 17, 2024
@akwaed
Copy link
Author

akwaed commented Oct 17, 2024

addresses issue #2398
Screenshot 2024-10-17 at 9 43 51 AM

@akwaed akwaed closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant