Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extern "C" to hw_clock_hfxo_request and int hw_clock_hfxo_release #55

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

positron96
Copy link
Contributor

@positron96 positron96 commented Jul 31, 2024

Add extern "C" to hw_clock_hfxo_request and int hw_clock_hfxo_release declarations.

These functions are defined Arduino wiring.c, and there they are defined as extern "C". They are not part of wiring.h though,
but are only declared in nrf.h, where they don't have "C" linkage. So any attempt to use these functions in cpp code fails to link.

@h2zero
Copy link
Owner

h2zero commented Nov 2, 2024

Thanks! Sorry I didn't get to this sooner. Good call, I didn't expect any app code to use these but why not?

@h2zero h2zero merged commit ab9a4a3 into h2zero:master Nov 13, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants