Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAT-119 JAT-120 - change quality label to Q Factor and change gain range to [-20 , 20] #59

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

JAT-119 JAT-120 - change quality label to Q Factor and change gain range to [-20 , 20] #59

wants to merge 2 commits into from

Conversation

chintav1
Copy link
Collaborator

@chintav1 chintav1 commented Oct 2, 2023

No description provided.

@chintav1 chintav1 changed the title JAT-120 - change quality label to Q Factor and some renaming JAT-119 JAT-120 - change quality label to Q Factor and change gain range to [-20 , 20] Oct 2, 2023
selinali2010
selinali2010 reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@selinali2010 selinali2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good but it looks like unit tests are failing. I think there's still some leftover references to quality that need to be changed to qfactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selinali2010 selinali2010 selinali2010 left review comments

@h39s h39s Awaiting requested review from h39s

@xenown xenown Awaiting requested review from xenown

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chintav1 @selinali2010