Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAT-105 Config File Selection Prompt #61

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

JAT-105 Config File Selection Prompt #61

wants to merge 12 commits into from

Conversation

selinali2010
Copy link
Collaborator

Summary

  • Add error case for when no config file is found
  • Add settings modal to proactively change the config file

BE Changes

  • Save configFilePath to the state
  • Add new updateConfigFilePath functionality
  • Add check for config file validity prior to all state.txt changes to ensure the error modal is surfaced ASAP

UI Changes

  • Add new FilePicker component
  • Add settings icon to the title bar

Refactor

  • Change Modal to be a more simple component and shrink width
  • Create ConfirmationModal for handling prereq error modals
  • Move title bar to within the App instead of in the header tag to allow for better control
  • Improve error title text to better fit the context
  • Rename setGraphViewOn to be setIsGraphViewOn

Fixes

  • Add try catch around setGain and setMainPreAmp calls
  • Add await in front of setMainPreAmp call

Testing

  • Add AppContext tests to App.test.tsx to validate error modals

Screenshots

Settings gear icon in the title bar:

image

Settings modal:

image

Missing config file error modal:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant