-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature posix drivers loading #151
Conversation
Good feature it maybe solver the problems of the modules loding on usb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Whats up buddy, how its going?
Please confirm if:
- Demo sample was tested on real hardware with these changes
- Demo sample was tested on PCSX2 with these changes
Proofs are appreciated.
engine/inc/irx/irx_loader.hpp
Outdated
@@ -27,6 +27,7 @@ class IrxLoader { | |||
void loadSio2man(const bool& verbose); | |||
void loadPadman(const bool& verbose); | |||
void loadLibsd(const bool& verbose); | |||
void loadPOSIX(const bool& verbose); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe loadIO()
? I think that POSIX name is too generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good name, I'll refactor this.
The DEMO was tested in the PCSX2 but no in the real hardware.
I'll certify it's working on both of them beforo update the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good name, I'll refactor this. The DEMO was tested in the PCSX2 but no in the real hardware. I'll certify it's working on both of them beforo update the PR
I totally forgot about these pending checks. I'll test in the real hardware and comeback with the results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be called load extended IO or something...
The POSIX trick is caused by the libcglue library.
fileXio and iomanX are just eXtended I/O modules, that co-exist with their stock versions (rom0:IOMAN
, rom0:FILEIO
)
Would be cool to have progress on this, since i'll be helping @Wolf3s to add iHDD Support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wellinator over here ⬆️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys! Thx for the suggestions.
Gonna finish it rn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a new branch based on yours, i think you don't need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing in the real hardware
Okay! All nice. |
@Wellinator Could you please change the Thanks! |
Sure, no problem |
I've renamed to loadIO as you suggested a while ago! |
It load the fileXio and iomanX needed for reading/writing from FS in the PS2.
It fixes the writeLogsToFile function in the real hardware using the USB drivers as well.