feat(Resolve address): use field dalsiUdaje #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pionl
reviewed
Nov 8, 2024
| if ($addressExists === false && isset($json->dalsiUdaje[0]->sidlo[0]->sidlo)) { | ||
| $addressExists = self::updateAddress($data, $json->dalsiUdaje[0]->sidlo[0]->sidlo); | ||
| if ($addressExists === false) { | ||
| $additionalData = isset($json->dalsiUdaje) ? self::prepareForAddress($json->dalsiUdaje) : []; |
There was a problem hiding this comment.
pro lepší čitelnost bych to hodil do private funkce a využil bych early returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probléme je, že v adresa je jen z části vyplněná podle hlavního zdroje.
Projdu field
dalsiUdajekde se koukám na pravniForma a datovyZdroj, datovyZdroj mám podle mnou definované priority['rzp', 'res', 'vr']. V nich hledám adresy a pokud nějakou najdu, tak ji použiji.