rpc unit test 100% coverage (#72)

h4ndzdatm0ld · Jul 9, 2023 · 8cb11ae · 8cb11ae
1 parent 347d1d2
commit 8cb11ae
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -132,6 +132,23 @@ def sros_rpc_payload():
         """
 
 
+@pytest.fixture(scope="function", autouse=True)
+def sros_rpc_payload_action():
+    return """
+<action xmlns="urn:ietf:params:xml:ns:yang:1">
+    <admin xmlns="urn:nokia.com:sros:ns:yang:sr:oper-admin">
+        <clear>
+            <security>
+                <password-history>
+                    <all/>
+                </password-history>
+            </security>
+        </clear>
+    </admin>
+</action>
+        """
+
+
 def xml_dict(xml: str) -> Dict[str, Any]:
     """Convert XML to Dict.
 

diff --git a/tests/test_data/schema_path/nokia-conf-aaa.yang b/tests/test_data/schema_path/nokia-conf-aaa.yang
diff --git a/tests/unit/test_netconf_rpc.py b/tests/unit/test_netconf_rpc.py
@@ -23,6 +23,20 @@ def test_netconf_rpc_success(ssh, nornir, sros_rpc_payload):
     assert result[DEVICE_NAME].result.rpc.ok
 
 
+@patch("ncclient.manager.connect_ssh")
+def test_netconf_rpc_success_action(ssh, nornir, sros_rpc_payload_action):
+    """Test NETCONF rpc action (namespace set), no defined manager."""
+    response_rpc = MagicMock()
+    response = MagicMock()
+    response.rpc.return_value = response_rpc
+    ssh.return_value = response
+
+    nr = nornir.filter(name=DEVICE_NAME)
+    result = nr.run(netconf_rpc, payload=sros_rpc_payload_action)
+    assert not result[DEVICE_NAME].failed
+    assert result[DEVICE_NAME].result.rpc.ok
+
+
 @patch("ncclient.manager.connect_ssh")
 def test_netconf_rpc_manager_set(ssh, nornir, sros_rpc_payload):
     """Test NETCONF rpc, with manager option set."""