Fix decrementing tasks left for non-task exercises #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
Column.isTaskfunction does not report a content type to be a task (usually scorable), but the content type sends out xAPI statements, then Interactive Book may decrease the number of tasks left by 1 and this leads to a wrong count of interactions on the summary screen.This can, for instance, happen for Agamotto that is not considered to be a task (not scored), but sends out xAPI
completedonce all images have been shown.When merged in, the number of tasks left will only be reduced by 1 if the instance at hand is considered to be a task.