Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Download params #712

Merged
merged 8 commits into from
Nov 3, 2024
Merged

fix: Download params #712

merged 8 commits into from
Nov 3, 2024

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Oct 28, 2024 •
edited
Loading

Referring to second remark of #635

fixes:

  • add_download_task_from_url
    • download_url param is str
    • new param download_dir
    • new param archive_password
  • add_download_task_from_file
    • download_file param is str
    • new param download_dir
    • new param archive_password

adds add_download_task_from_urls

@Quentame Quentame added the bug Something isn't working label Oct 28, 2024
@Quentame Quentame force-pushed the fix/download_params branch from d3d3163 to f75f44b Compare November 3, 2024 21:10
@Quentame Quentame marked this pull request as ready for review November 3, 2024 21:20
@Quentame Quentame merged commit bdc10f0 into master Nov 3, 2024
21 checks passed
@Quentame Quentame deleted the fix/download_params branch November 3, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Quentame