fix remove at wrong index #418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaz-toc is attempting to deploy a commit to the Code for Japan Team on Vercel. A member of the Team first needs to authorize it. |
kaz-toc
commented
Sep 30, 2023
| append: (v: any) => void; | ||
| remove: UseFieldArrayRemove; | ||
| }; | ||
|
|
||
| const NFTAttributesForm: FC<Props> = ({ control, nfts, append, remove }) => { | ||
| const NFTAttributesForm: FC<Props> = ({ control, nfts, fields, append, remove }) => { |
There was a problem hiding this comment.
react-hook-formの使い方が少し違っているようでした。
もう少し修正する必要がありそうです
|
@kaz-toc 早速ありがとうございます！ https://github.com/hackdays-io/mint-rally/blob/staging/CONTRIBUTING.md
|
|
こちら、ブランチ名を見る限り #303 の対応していただいている途中ですかね、ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip