Fix zoom and bad delegate subscription execution ordering #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toberge
reviewed
Nov 17, 2024
| onFireNoAmmo = null; | ||
| onFireStart = null; | ||
| onInitializeBullet = null; | ||
| onReload = null; |
There was a problem hiding this comment.
You're missing onInitializeGun and the delegates on the ProjectileController
toberge
reviewed
Nov 17, 2024
| DeSubscribeDelegates(); | ||
| } | ||
|
|
||
| public void DeSubscribeDelegates() |
There was a problem hiding this comment.
Perhaps replace De with Un 😔
toberge
reviewed
Nov 17, 2024
| @@ -216,8 +228,11 @@ private void RpcFireWithNoAmmo() | |||
|
|
|||
| private void FireGun() | |||
| { | |||
| if (stats == null) | |||
There was a problem hiding this comment.
huh, so this was necessary? 🤔
toberge
force-pushed
the
fix/weapon-switching
branch
from
8dbfb0a
to
044aa46
Compare
toberge
force-pushed
the
fix/weapon-switching
branch
from
044aa46
to
20b0c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.